fix(extension): drop dead issue-page content-script match by jsdevninja · Pull Request #7487 · JSONbored/loopover

jsdevninja · 2026-07-20T12:25:25Z

Summary

Remove https://github.com/*/*/issues/* from the maintainer overlay content-script matches so the extension no longer loads on issue pages it never acts on.
Narrow matchGitHubPageTarget to pull-request URLs only and simplify matchPullRequestTarget now that kind: "issue" cannot be produced.
Update test/unit/extension-content.test.ts with a regression that issue URLs are out of scope and that the manifest no longer declares an issues match.

Closes #7462

Scope

The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
I linked a currently open issue this PR resolves (e.g. Closes #123) — a linked open issue is required for every contributor PR.

Validation

If any required check was skipped, explain why:

Extension-only Option A fix (apps/** is outside Codecov coverage.include). Ran npx vitest run test/unit/extension-content.test.ts (4 pass). Remaining test:ci surface is unchanged and will run in CI.

Safety

No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
API/OpenAPI/MCP behavior is updated and tested where needed.
UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — no visible overlay change. PR pages still mount the same private pull-context overlay; issue pages already did nothing and are now simply not matched by the content script.

Notes

Implements Option A from fix(extension): content.js's issue-page detection is dead code; manifest.json's issues/* match does nothing #7462 (narrow scope). Does not touch apps/loopover-miner-extension, which correctly targets issue pages.

Co-authored-by: Cursor <cursoragent@cursor.com>

superagent-security · 2026-07-20T12:25:45Z

Superagent didn't find any vulnerabilities or security issues in this PR.

codecov · 2026-07-20T12:33:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.39%. Comparing base (9ecf8c1) to head (1b17af3).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7487      +/-   ##
==========================================
- Coverage   91.41%   91.39%   -0.02%     
==========================================
  Files         717      717              
  Lines       73032    73032              
  Branches    21636    21635       -1     
==========================================
- Hits        66762    66751      -11     
- Misses       5227     5234       +7     
- Partials     1043     1047       +4

Flag	Coverage Δ
shard-1	`34.34% <ø> (-0.02%)`	⬇️
shard-2	`39.11% <ø> (ø)`
shard-3	`36.15% <ø> (-0.09%)`	⬇️
shard-4	`43.33% <ø> (-0.05%)`	⬇️
shard-5	`31.89% <ø> (-0.01%)`	⬇️
shard-6	`31.47% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

loopover-orb · 2026-07-20T12:36:39Z

Tip

✅ LoopOver review result - approve/merge recommended

_{Review updated: 2026-07-20 12:37:13 UTC}

3 files · 1 AI reviewer · no blockers · readiness 98/100 · CI green · clean

✅ Suggested Action - Approve/Merge

safe to merge

Review summary
This PR narrows the maintainer overlay's content-script to pull-request pages only, removing the dead issue-page classification path and the unused manifest match for `issues/*`. The change is correct and well-scoped: `matchGitHubPageTarget` now only matches `pull/`, `matchPullRequestTarget` is simplified since a null check now covers the only non-match case, and the test file is updated in lockstep (manifest assertion, null-return assertion for issue URLs, and updated type signature). It closes #7462 cleanly and the regression tests cover the new behavior.

Nits — 3 non-blocking

content.js:8-9 the added comment cites 'fix(extension): content.js's issue-page detection is dead code; manifest.json's issues/* match does nothing #7462' inline; repo convention elsewhere (e.g. loopover-miner-extension/content.js) keeps such history out of inline code comments in favor of PR/README notes — verify this matches maintainer preference.
The manifest test only checks `content_scripts[0]`; if a second content-script block were ever added, this index-based access could silently start asserting against the wrong entry, though that's a hypothetical for now.
Consider moving the `fix(extension): content.js's issue-page detection is dead code; manifest.json's issues/* match does nothing #7462` rationale comment to the PR description only, consistent with other files in the repo that avoid embedding issue numbers in inline comments (apps/loopover-miner-extension/content.js does the opposite in one spot, so this may already be accepted practice — worth confirming).

Decision drivers

✅ Code review — No blockers (1 reviewer)
✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#7462
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 193 registered-repo PR(s), 120 merged, 38 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	jsdevninja; Gittensor profile; 193 PR(s), 38 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: minor

Linked issue satisfaction

Addressed
The diff implements Option A exactly as specified: manifest.json drops the issues/* match, matchGitHubPageTarget is narrowed to pull-request-only classification, matchPullRequestTarget's dead discard branch is simplified, and the test file is updated with a regression asserting issue URLs no longer match plus a manifest assertion.

Review context

Author: jsdevninja
Role context: outside_contributor
Public audience mode: oss maintainer
Lane context: Repository is configured for direct PR review.
Public profile languages: JavaScript, Swift, C, CSS, MDX, Python, TypeScript, Vue
Official Gittensor activity: 193 PR(s), 38 issue(s).
PR-specific overlap: none found.

Contributor next steps

Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

Related work = same linked issue, overlapping active PRs, or title/path similarity.
Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

@loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
@loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

Visual preview

Route	Viewport	Before (production)	After (this PR's preview)	Diff
`/`	desktop	_{before /}	_{after /}	—
`/`	mobile	_{before / (mobile)}	_{after / (mobile)}	—

Click any thumbnail to open the full-size screenshot. Before = production · After = this PR's preview deploy.

Scroll preview

Route	Before (production)	After (this PR's preview)
`/`	_{before / (scroll)}	—

A short scroll-through clip (desktop) — click either thumbnail to open the full animation. Evidence for scroll-linked behavior a single screenshot can't show.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

Re-run LoopOver review

loopover-orb

LoopOver approves — the gate is satisfied and CI is green.

…js (JSONbored#8023) matchPullRequestTarget duplicated matchGitHubPageTarget's logic minus the kind field and was left stranded by JSONbored#7487/JSONbored#7462 (which narrowed the content-script match to pull/* only). It is unreferenced in production -- surfaced solely through the __loopoverContentInternals test hook. Remove the function and its export entry, and drop the now-orphaned assertions in extension-content.test.ts; the retained matchGitHubPageTarget coverage confirms the script still loads and routes unchanged.

fix(extension): drop dead issue-page content-script match

1b17af3

Co-authored-by: Cursor <cursoragent@cursor.com>

jsdevninja requested a review from JSONbored as a code owner July 20, 2026 12:25

loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 20, 2026

loopover-orb Bot assigned jsdevninja Jul 20, 2026

loopover-orb Bot approved these changes Jul 20, 2026

View reviewed changes

loopover-orb Bot merged commit 87766eb into JSONbored:main Jul 20, 2026
15 checks passed

JSONbored mentioned this pull request Jul 22, 2026

matchPullRequestTarget is dead code left behind in loopover-extension/content.js by #7487's issue-page match removal #8023

Closed

2 tasks

loopover-orb Bot mentioned this pull request Jul 22, 2026

fix(extension): remove stranded matchPullRequestTarget (#8023) #8032

Closed

24 tasks

joaovictor91123 mentioned this pull request Jul 22, 2026

fix(extension): remove dead matchPullRequestTarget from content.js #8037

Closed

6 tasks

lourincedaging0-commits mentioned this pull request Jul 22, 2026

fix(extension): remove dead matchPullRequestTarget from content script #8045

Closed

xfodev mentioned this pull request Jul 22, 2026

fix(extension): remove dead matchPullRequestTarget from content script #8048

Closed

4 tasks

real-venus mentioned this pull request Jul 22, 2026

refactor(extension): remove dead matchPullRequestTarget from content.js (#8023) #8049

Closed

12 tasks

This was referenced Jul 22, 2026

chore(extension): remove dead matchPullRequestTarget from content.js #8050

Closed

chore(extension): remove dead matchPullRequestTarget; pin extension endpoints to the API contract #8053

Closed

kai392 mentioned this pull request Jul 22, 2026

fix(extension): remove stranded matchPullRequestTarget duplicate from content.js (#8023) #8054

Closed

5 tasks

milosde111 mentioned this pull request Jul 22, 2026

fix(extension): remove stranded matchPullRequestTarget and keep scoped CI coverage (#8023) #8062

Merged

24 tasks

Navigation Menu

Uh oh!

fix(extension): drop dead issue-page content-script match - #7487

fix(extension): drop dead issue-page content-script match#7487
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
jsdevninja:fix/extension-issue-match-dead-code

jsdevninja commented Jul 20, 2026 •

edited

Loading

Uh oh!

superagent-security Bot commented Jul 20, 2026

Uh oh!

codecov Bot commented Jul 20, 2026 •

edited

Loading

Uh oh!

loopover-orb Bot commented Jul 20, 2026 •

edited

Loading

✅ LoopOver review result - approve/merge recommended

Uh oh!

loopover-orb Bot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

jsdevninja commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Scope

Validation

Safety

UI Evidence

Notes

Uh oh!

superagent-security Bot commented Jul 20, 2026

Uh oh!

codecov Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

loopover-orb Bot commented Jul 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ LoopOver review result - approve/merge recommended

Uh oh!

loopover-orb Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jsdevninja commented Jul 20, 2026 •

edited

Loading

codecov Bot commented Jul 20, 2026 •

edited

Loading

loopover-orb Bot commented Jul 20, 2026 •

edited

Loading